Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boltdb shipper deletion fixes #3746

Merged

Conversation

sandeepsukhani
Copy link
Contributor

What this PR does / why we need it:
It comprises of 2 fixes related to deletion support for boltdb-shipper:

  1. I had used break instead of return in a select case which caused the loop to continue and not stop the compactor.
  2. We need to skip compaction or apply retention on delete requests table.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandeepsukhani sandeepsukhani merged commit 3b26c63 into grafana:main May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants